Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MCOMPILER-558] compileSourceRoots in testCompile should be writable #209

Merged
merged 2 commits into from Nov 23, 2023
Merged

[MCOMPILER-558] compileSourceRoots in testCompile should be writable #209

merged 2 commits into from Nov 23, 2023

Conversation

lorenzsimon
Copy link
Contributor

@lorenzsimon lorenzsimon commented Nov 22, 2023 •
edited

JIRA: https://issues.apache.org/jira/browse/MCOMPILER-558

Projects should be able to configure the compileSourceRoots also in the testCompile goal (like in the compile goal)

This causes a warning because the parameter is set as read-only.

@lorenzsimon
[MCOMPILER-558] compileSourceRoots in testCompile should be writable
70132ac 
Make compileSourceRoots read/write so that it can be configured
@slawekjaranowski
Copy link
Member

@lorenzsimon - please preserve a line from PR template:

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

in description

michael-o
michael-o approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be straight forward...

@gnodet gnodet merged commit e5375fd into apache:master Nov 23, 2023
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
4 participants
@lorenzsimon @slawekjaranowski @michael-o @gnodet