Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-558] compileSourceRoots in testCompile should be writable #209

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

lorenzsimon
Copy link
Contributor

@lorenzsimon lorenzsimon commented Nov 22, 2023

JIRA: https://issues.apache.org/jira/browse/MCOMPILER-558

Projects should be able to configure the compileSourceRoots also in the testCompile goal (like in the compile goal)

This causes a warning because the parameter is set as read-only.

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
CaiJingLong Caijinglong
Make compileSourceRoots read/write so that it can be configured
@slawekjaranowski
Copy link
Member

@lorenzsimon - please preserve a line from PR template:

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

in description

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be straight forward...

Verified

This commit was signed with the committer’s verified signature.
CaiJingLong Caijinglong
@slawekjaranowski slawekjaranowski added the enhancement New feature or request label Nov 22, 2023
@gnodet gnodet merged commit e5375fd into apache:master Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants