Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-542] Clean JDK patch version in module-info.class #208

Merged
merged 3 commits into from Nov 28, 2023

Conversation

jorsol
Copy link
Contributor

@jorsol jorsol commented Nov 4, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes. https://issues.apache.org/jira/browse/MCOMPILER-542
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Closes #197

@jorsol
Copy link
Contributor Author

jorsol commented Nov 4, 2023

@hboutemy I take your commit from #197 as a base to test.

Opened in draft mode since this might require some feedback.

@jorsol jorsol force-pushed the MCOMPILER-542 branch 2 times, most recently from 1b9c979 to 91864fd Compare November 7, 2023 12:02
@jorsol jorsol marked this pull request as ready for review November 7, 2023 12:04
@jorsol
Copy link
Contributor Author

jorsol commented Nov 7, 2023

This should be ready for review.

@jorsol
Copy link
Contributor Author

jorsol commented Nov 17, 2023

Any feedback on this?

@hboutemy
Copy link
Member

sorry, I've been busy: I'll work on it this WE, I promise

@jorsol jorsol force-pushed the MCOMPILER-542 branch 3 times, most recently from e93b690 to 95d69e4 Compare November 24, 2023 08:06
Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
@hboutemy
Copy link
Member

PR https://github.com/jorsol/maven-compiler-plugin/pull/1/files provided (PR on a PR :) )

@hboutemy hboutemy merged commit d721f0f into apache:master Nov 28, 2023
118 checks passed
@jorsol jorsol deleted the MCOMPILER-542 branch November 28, 2023 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants