Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-549] Improve log message in case of recompilation #201

Merged

Conversation

BrowneMonke
Copy link
Contributor

@BrowneMonke BrowneMonke commented Oct 13, 2023

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@BrowneMonke BrowneMonke changed the title idk refactored to immutableOutputFile => getLog.info: "Immutable Single Output File" (line 881, 893) [MCOMPILER-499] - idk refactored to immutableOutputFile => getLog.info: "Immutable Single Output File" (line 881, 893) Oct 13, 2023
@mthmulders mthmulders changed the title [MCOMPILER-499] - idk refactored to immutableOutputFile => getLog.info: "Immutable Single Output File" (line 881, 893) [MCOMPILER-549] - idk refactored to immutableOutputFile => getLog.info: "Immutable Single Output File" (line 881, 893) Oct 13, 2023
@mthmulders mthmulders changed the title [MCOMPILER-549] - idk refactored to immutableOutputFile => getLog.info: "Immutable Single Output File" (line 881, 893) [MCOMPILER-549] Improve log message in case of recompilation Oct 13, 2023
@mthmulders mthmulders self-requested a review October 13, 2023 13:17
@mthmulders
Copy link
Contributor

I ran mvn clean verify and mvn -Prun-its clean verify on my machine and the results are good. Approving CI run.

Copy link
Contributor

@mthmulders mthmulders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, big improvement. Thank you!

@olamy olamy merged commit 628c333 into apache:master Oct 17, 2023
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants