Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MCOMPILER-544] don't add items to classpath that are not used for that #198

Merged
merged 1 commit into from Oct 3, 2023

Conversation

laeubi
Copy link

@laeubi laeubi commented Sep 20, 2023

Currently simply all kind of items are added to the classpath leading to strange errors in the ECJ compiler plugin because it does not know how to handle pom or other possible types.

This adds an additional check to see if the artifact handler actually claims the itme should be put on the classpath,

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MCOMPILER-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Currently simply all kind of items are added to the classpath leading to
strange errors in the ECJ compiler plugin because it does not know how
to handle pom or other possible types.

This adds an additional check to see if the artifact handler actually
claims the itme should be put on the classpath,
Copy link
Contributor

@gnodet gnodet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawekjaranowski
Copy link
Member

Cen we add example from jira as IT?

@laeubi
Copy link
Author

laeubi commented Sep 21, 2023

Cen we add example from jira as IT?

I'm not that familiar with compiler-itests but it should be enough to check that no ERROR printout is there when executing the given pom example on a project that has at least one dummy source file so compilation is triggered...

@laeubi
Copy link
Author

laeubi commented Sep 30, 2023

@slawekjaranowski can you help with the test-case here? I anything else needed or does it look sane?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants