Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove references to old Maven versions. #194

Merged
merged 2 commits into from Jun 20, 2023
Merged

Remove references to old Maven versions. #194

merged 2 commits into from Jun 20, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jun 19, 2023

In 2023 assume everyone is on 3.3.1 or later.

@elharo elharo requested a review from michael-o June 19, 2023 20:27
@slachiewicz
Copy link
Member

I hope You remember discussion on ML about minimum supported Maven version in all our plugins - so far 3.2.5 is minimal for users https://maven.apache.org/docs/history.html#maven-3-6-x-and-before and You strongly voted against setting it to 3.5.4

@elharo
Copy link
Contributor Author

elharo commented Jun 19, 2023

What we support and what we spend time calling out in documentation are two different things. Maven 2 is definitely dead.

@slachiewicz
Copy link
Member

Remove references to old Maven versions. In 2023 assume everyone is on 3.3.1 or later. if You say that this is true - so we can bump minimal supported Maven version for plugins to 3.3.1 and not be locked to 3.2.5 ;-)

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I agree with @slachiewicz, I think we can do this and not waste more time for another PR in a year. People won't say thank you.

@elharo elharo merged commit ae3a423 into master Jun 20, 2023
137 of 142 checks passed
@elharo elharo deleted the maven2 branch June 20, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants