[MCOMPILER-501] compileSourceRoots parameter should be writable #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawekjaranowski
approved these changes
Dec 9, 2022
There was a problem hiding this comment.
Please link with https://issues.apache.org/jira/browse/MCOMPILER-501
cstamas
approved these changes
Dec 9, 2022
olamy
approved these changes
Dec 9, 2022
Make compileSourceRoots read/write so that it can be used in multi-release jars without issuing a warning
gnodet
force-pushed
the
remove-warning
branch
from
9471824
to
8daad08
Compare
gnodet
changed the title
|
When will there be a new release with this change applied? |
|
@norrisjeremy it will be in a few days https://lists.apache.org/thread/yplrmgqzfwrr7j2ds19lf675596llp54 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.apache.org/jira/browse/MCOMPILER-501
When using multi-release JARs, the way is to configure the plugin, see https://github.com/apache/maven-compiler-plugin/blob/master/src/it/multirelease-patterns/singleproject-runtime/pom.xml#L92-L111
This causes a warning because the parameter is set as read-only.