Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MBUILDCACHE-74] Clean local cache for any artifact #110

Conversation

mweirauch
Copy link
Contributor

@mweirauch mweirauch commented Nov 20, 2023

This MR cleans up any cached local build, no matter if the module/project in question has a package phase.

I noticed stale cache entries for our parent POM in the local build cache, which were not cleaned up.

--

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a MBUILDCACHE JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MBUILDCACHE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MBUILDCACHE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@mweirauch mweirauch force-pushed the mbuildcache-74-clean-local-cache-for-any-artifact branch from 50b4b74 to 15baafb Compare November 21, 2023 10:46
@mweirauch mweirauch marked this pull request as ready for review November 21, 2023 10:47
@mweirauch mweirauch force-pushed the mbuildcache-74-clean-local-cache-for-any-artifact branch from 15baafb to b6e9ff0 Compare November 21, 2023 12:43
@olamy olamy added the bug Something isn't working label Nov 21, 2023
Not just the ones which have a package phase. Otherwise the cached
builds will be kept forever.
@mweirauch mweirauch force-pushed the mbuildcache-74-clean-local-cache-for-any-artifact branch from b6e9ff0 to 532a24d Compare November 22, 2023 08:49
@olamy olamy merged commit 7910490 into apache:master Nov 22, 2023
14 checks passed
@mweirauch mweirauch deleted the mbuildcache-74-clean-local-cache-for-any-artifact branch November 22, 2023 12:37
@mweirauch
Copy link
Contributor Author

Oops, I didn't pay attention and force pushed a local change to the root pom.xml which helps vscode to actually recognize the generated sources folder for the mdo generated models. This now landed on master. I am very sorry for this mistake!

Please let me know if you want to keep it. It shouldn't hurt the build, but it's still IDE specific. (vscode uses Eclipse' m2e backend which needs some help with the classpath extension; dunno specifically if this change also helps Eclipse users as well)

@olamy
Copy link
Member

olamy commented Nov 22, 2023

@mweirauch no worries. My bad I didn’t check the PR correctly with last commit.
Please just create a PR to revert this.

olamy added a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Olivier Lamy <olamy@apache.org>
@olamy
Copy link
Member

olamy commented Nov 22, 2023

@mweirauch done with #114

olamy added a commit that referenced this pull request Nov 22, 2023
Signed-off-by: Olivier Lamy <olamy@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants