[MASSEMBLY-775] for review #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we want to have somehow portable builds we also need to treat / as absolute on Windows. This will be treated as disk-relative. That means if you build on c: then /somedir will be c:\somedir on a Windows box.
…aths The old code did log some warn based on an absolute path in the outputDirectory. But that's actually irrelevant as this is always the directory inside the zip/tar, etc. That means it is _always_ interpreted as relative! The only possible problem is the 'directory' attribute which denotes the source path!
|
I've replaced Easymock with Mockito, so this PR needs to be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! up for review before I gonna commit it.