Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(services/redis): add redis cluster support #2858

Merged
merged 11 commits into from Aug 15, 2023
Merged

feat(services/redis): add redis cluster support #2858

merged 11 commits into from Aug 15, 2023

Conversation

G-XD
Copy link
Contributor

@G-XD G-XD commented Aug 13, 2023

Xuanwo
Xuanwo previously approved these changes Aug 14, 2023
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, please make CI happy, thanks!

@Xuanwo
Copy link
Member

Xuanwo commented Aug 14, 2023

vishnudxb/redis-cluster@1.0.5 is not allowed to be used in apache/incubator-opendal.

Maybe we can use docker or docker-compose setup?

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit a31ad05 into apache:main Aug 15, 2023
30 checks passed
@G-XD G-XD deleted the feat_redis_cluster branch August 15, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants