Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS, Core: Replace .withFailMessage() usage with .as() #10000

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

nastra
Copy link
Contributor

@nastra nastra commented Mar 19, 2024

We almost never want to use .withFailMessage() as that will override any enriched contextual information that AssertJ generally provides about actual/expected. It's better to use .as() to add some description to the check being done, which allows to still show contextual information about actual/expected if the assertion ever fails.

We almost never want to use `.withFailMessage()` as that will override
any enriched contextual information that AssertJ generally provides
about actual/expected. It's better to use `.as()` to add some
description to the check being done, which allows to still show
contextual information about actual/expected if the assertion ever
fails.
@nastra nastra merged commit f425dc7 into apache:main Mar 19, 2024
41 checks passed
@nastra nastra deleted the replace-with-fail-msg-usage branch March 19, 2024 16:05
zachdisc pushed a commit to zachdisc/iceberg that referenced this pull request Dec 23, 2024
We almost never want to use `.withFailMessage()` as that will override
any enriched contextual information that AssertJ generally provides
about actual/expected. It's better to use `.as()` to add some
description to the check being done, which allows to still show
contextual information about actual/expected if the assertion ever
fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants