chore(typescript): migrate core library to TS #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jyyjy
requested changes
May 28, 2024
EandrewJones
commented
May 28, 2024
EandrewJones
force-pushed
the
442-migrate-to-typescript
branch
3 times, most recently
from
115517b
to
b27c542
Compare
Migrates entire library to TS, including support for TS in the build artifacts. Replaces Sinon with Jest for testing to resolve ESM import issues in tests. Author: Evan Jones <evan.a.jones3@gmail.com>
EandrewJones
force-pushed
the
442-migrate-to-typescript
branch
from
b27c542
to
1e53be8
Compare
|
@Jyyjy I had to update a few more things to get license checks to pass since the build changed. Otherwise, conflicts should be good to go. I'll let you take a look at resolve your review before merging. |
Jyyjy
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates entire library to TS, including support for TS in the build artifacts. Replaces Sinon with Jest for testing to resolve ESM import issues in tests.
Closes: #442
Author: Evan Jones evan.a.jones3@gmail.com