Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(typescript): Migrate codebase to typescript #442

Closed
EandrewJones opened this issue May 7, 2024 · 0 comments · Fixed by #457
Closed

Feature(typescript): Migrate codebase to typescript #442

EandrewJones opened this issue May 7, 2024 · 0 comments · Fixed by #457
Assignees

Comments

@EandrewJones
Copy link
Contributor

Problem

There are an unknown number of lurking type issues (see, for example, #441) all of which would be solved by migrating to typescript. What's more, we employ a strategy pattern in a number of places such as the authHeaderCallbacks and to enforce the strategy we write explicit typechecks in javascript.

Both of these point to the need/desire for type support to improve the developer experience.

Proposal

Migrate the code base to typescript in a single push.

Risks

  • This will be a large PR.
  • You never know whether one of your dependencies won't play nice with TS.
  • Typescript also means that new contributors and developers will need to adhere to the type system, assuming we enforce this via pre-commit hooks/linters.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant