Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress self update for windows CI runner #9661

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

jayzhan211
Copy link
Contributor

@jayzhan211 jayzhan211 commented Mar 18, 2024

Which issue does this PR close?

Close #9653

Sometimes CI fails because of rustup, we can re-reun the job and pray for the success.

rustup update stable
  rustup toolchain install stable
  rustup default stable
  rustup component add rustfmt
  shell: C:\Program Files\Git\bin\bash.EXE --noprofile --norc -e -o pipefail {0}
info: syncing channel updates for 'stable-x86_64-pc-windows-msvc'

  stable-x86_64-pc-windows-msvc unchanged - rustc 1.76.0 (07dca489a 2024-02-04)

info: checking for self-update
info: downloading self-update
D:\a\_temp\1c8b34cc-212a-[46](https://github.com/apache/arrow-datafusion/actions/runs/8319817263/job/22763668481?pr=9651#step:3:49)4d-8031-14d0aca81a56.sh: line 2: /c/Users/runneradmin/.cargo/bin/rustup: Device or resource busy
warning: tool `rust-analyzer` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `rustfmt` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.
warning: tool `cargo-fmt` is already installed, remove it from `C:\Users\runneradmin\.cargo\bin`, then run `rustup update` to have rustup manage this tool.

There is a workaround solution so we can avoid manually re-run CI job.
Downside is that we need to manual update latest rust version for window.

Possible issue

rust-lang/rustup#2441
rust-lang/rustup#3709

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
@jayzhan211 jayzhan211 changed the title Suppress self update for window [CI] Suppress self update for window Mar 18, 2024
@jayzhan211 jayzhan211 marked this pull request as ready for review March 18, 2024 11:28
@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Mar 18, 2024

I create a new label CI/CD pipeline mainly for fix that related to CI, not sure how to automatic add label based on the file change yet

Let me introduce more lable, so one for critical issue that is blocking every PR, another is normal that happens sometime like this one, the last one is the normal feature request.

@jayzhan211 jayzhan211 added ci: critial critical issue that is blocking every PR ci: important CI changes that fails sometimes and can be solved by re-run the job and removed ci: critial critical issue that is blocking every PR labels Mar 18, 2024
@jayzhan211 jayzhan211 changed the title [CI] Suppress self update for window Suppress self update for window Mar 18, 2024
@jayzhan211
Copy link
Contributor Author

jayzhan211 commented Mar 18, 2024

ci: critial, ci: important and ci: feature

I think critical and feature are nice name, but unsure is there a better label for important

@alamb alamb changed the title Suppress self update for window Suppress self update for windows CI runner Mar 18, 2024
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb alamb added the development-process Related to development process of arrow-datafusion label Mar 18, 2024
@github-actions github-actions bot removed the development-process Related to development process of arrow-datafusion label Mar 18, 2024
@@ -38,8 +38,8 @@ runs:
- name: Setup Rust toolchain
shell: bash
run: |
rustup update stable
rustup toolchain install stable
# Avoid self update to avoid CI failures: https://github.com/apache/arrow-datafusion/issues/9653
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add the same for other OS?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@comphead I think we don't need to disable self update for other OS, the issue is window only. After the issue is solved, we can enable self update again.
@alamb

@alamb
Copy link
Contributor

alamb commented Mar 18, 2024

Merging to stop CI failures on main -- let's contemplate adding the same for other OS's (@comphead 's comment #9661 (comment)) as a follow on PR

@alamb alamb merged commit b0b329b into apache:main Mar 18, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: important CI changes that fails sometimes and can be solved by re-run the job
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CI Intermittent Fail in Setup Rust Toolchain
3 participants