Port ArrayRemove, ArrayRemoveN, ArrayRemoveAll to functions-array subcrate
#9656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
erenavsarogullari
force-pushed
the
Issue-9635
branch
2 times, most recently
from
ba89bed
to
1cfeb14
Compare
…ons-array subcrate
erenavsarogullari
force-pushed
the
Issue-9635
branch
from
1cfeb14
to
bce4e72
Compare
|
Current |
jayzhan211
reviewed
Mar 18, 2024
| array_except( | ||
| make_array(vec![lit(1), lit(2), lit(3)]), | ||
| make_array(vec![lit(1), lit(2)]), | ||
| ), |
There was a problem hiding this comment.
I think you accidentally remove it. Also, add remove's too
There was a problem hiding this comment.
Thanks for the review, addressed.
It seems like an issue from github |
jayzhan211
reviewed
Mar 18, 2024
| /// [[1, 2, 3], [2, 3, 4], [2, 3, 4]], [[1, 2, 3], [2, 3, 4], [3, 4, 5]], 1, false => [true, false, false] | ||
| /// ) | ||
| /// ``` | ||
| pub(crate) fn compare_element_to_list( |
There was a problem hiding this comment.
There are three duplicated code including this one, can you remove other two?
|
@erenavsarogullari Let me merge this first, those duplications can be removed later |
|
@jayzhan211 Thanks for the merge. I will address duplication by separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #9635.
What changes are included in this PR?
This PR aims to do following changes in terms of Epic #9285:
ArrayRemove,ArrayRemoveN,ArrayRemoveAllare ported tofunctions-arraysubcrate.Are these changes tested?
Yes, all
array.sltandunnest.sltbasedArrayRemove,ArrayRemoveN,ArrayRemoveAlltests are passed.Are there any user-facing changes?
No