(ios) issue-912: fix deployment to device #936
Conversation
cordova-ios used to use "mv -f" and it was replaced with fs-extra.moveSync. moveSync behaves differently than mv, which broke deployment to devices. This fixes the folder move and subsequently deployment to device (when using "cordova run ios --device ..."
There was a problem hiding this comment.
Thank you for taking a time to investigate and submit a PR. This change looks good to me, but I don't have a mac to actually test this myself. I'd like to see at least one other PMC member, preferably someone who can actually execute and test this code change.
|
The changes are correct and the files are copied over to the correct location. The app deploys to the phone but I noticed that only a black screen displays, no default app shown. If I open the project with Xcode and run on device, the application will launch normally and display default app content. I used an iPhone Xs w/ iOS 13.5.1 for this test. @imgos Is this the same behaviour you see? |
|
@erisu - I've been able to deploy two cordova apps to my ios devices (iphone 7 plus and iphone 8) successfully with this. I have not had an app build and then open with a black screen. I see there is an xcode project in the |
|
I'll give this PR a test today - codewise it looks good. Thanks for the investigation :) |
|
When is a release going to happen with this change? This is pretty crucial... |
|
We do not give any ETAs of new releases. |
|
It has been a month, is it complicated for you to release a patch? |
|
Hello ! Same here, hope it will be patch soon :) Thanks for the investigation ! |
|
Thanks for the pull request, I was facing this issue as well today. As a temporary workaround until this gets released to stable, you can either downgrade to 5.1.1 (latest version prior to 6.0.0) or use the latest nightly version. (Which you can find here under "versions".) Here's how to change the version of your iOS platform: To install the nightly version, simply replace |
Nightly builds should be reserved for testing only. But for this case, a safer workaround is to use a specific version, such as This will at least provide consistency over |
|
Downgrading to 5.1.1 is not an option as I will not start a brand new project using the old UIWebview... Apple won’t allow apps with any reference to it. The 6x version removes that reference and uses the WKWebView but has a bug that prevents the package from even getting deployed to your iOS device. A recent commit has resolved this but hasn’t made it into a release so I’m hard-coding the change for the time being... Anyone who wants to use this package is basically stuck doing this since no one is going to want to downgrade if they’re taking iOS deployment seriously... Apple won’t allow it. |
|
Do you have a link to the Apple docs where it talks about this? I'll have to deploy soon and I have some projects still on 5.1.1. |
|
Can we open a separate issue to address problems in the release process? What are the issues in the release process that make it difficult to release a patch? Once these are identified, maybe there are ways some of us can help automate the process. |
https://developer.apple.com/news/?id=12232019b https://developer.apple.com/documentation/uikit/uiwebview |
Exactly, at a minimum this should just be a patch, not a minor version release or requiring me to tag nightly or any of that... |
|
Sorry to interrupt here, but some comments are simply wrong. It is safe to use cordova-ios@5 with the WKWebView plugin. v6 simply integrated those changes into the core platform. @imgos please refer to https://www.apache.org/legal/release-policy.html#release-approval - we can’t alter the process much. And yes a patch is more work than a minor because we need to cherry pick to the correct branches etc. besides that, all development (no support!) discussions should take place via the dev mailing list. |
|
cordova-ios used to use "mv -f" and it was replaced with fs-extra.moveSync. moveSync behaves differently than mv, which broke deployment to devices. This fixes the folder move and subsequently deployment to device (when using "cordova run ios --device ..."
cordova-ios used to use "mv -f" and it was replaced with fs-extra.moveSync. moveSync behaves
differently than mv, which broke deployment to devices. This fixes the folder move and
subsequently deployment to device (when using "cordova run ios --device ..."
Platforms affected
Motivation and Context
This was motivated by wanting to run an ios app on the device. This worked in versions of cordova-ios <= 5.1.1 and was broken in 6.0.0 and 6.1.0.
fixes: #912
Description
Fix a file copy. The behavior of
moveSyncis not exactly the same asmv -fwhich was previously used.Testing
I have tested by deploying ios apps with
cordova run ios --devicefrom the command line. This restores the functionality from the old versions of cordova-ios.Checklist
(platform)if this change only applies to one platform (e.g.(android))