Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove q leftover #875

Merged
merged 1 commit into from May 28, 2020
Merged

fix: remove q leftover #875

merged 1 commit into from May 28, 2020

Conversation

erisu
Copy link
Member

@erisu erisu commented May 28, 2020

Motivation, Context & Description

  • Remove leftover q
  • Causes an issue when creating project with create binary.
TypeError: Api.createPlatform(...).done is not a function

Testing

  • create project with binary.
./bin/create /tmp/cdvTest com.foobar.cdvTest cdvTest
Creating Cordova project for the iOS platform:
	Path: ../../../../../../../../tmp/cordova-coho-tests/iosTest2
	Package: com.foobar.cdvTest
	Name: cdvTest
iOS project created with cordova-ios@6.0.0-dev

Checklist

  • I've run the tests to see all new and existing tests pass

@erisu erisu added this to the 6.0.0 milestone May 28, 2020
@erisu erisu requested a review from NiklasMerz May 28, 2020 06:54
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2020

Codecov Report

Merging #875 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #875   +/-   ##
=======================================
  Coverage   74.40%   74.40%           
=======================================
  Files          13       13           
  Lines        1676     1676           
=======================================
  Hits         1247     1247           
  Misses        429      429           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 970c843...64a4575. Read the comment docs.

@NiklasMerz NiklasMerz added this to Reviewer approved in Release Plan via automation May 28, 2020
Copy link
Member

@NiklasMerz NiklasMerz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, create project with binary works locally.

@erisu erisu merged commit 0f9329e into apache:master May 28, 2020
Release Plan automation moved this from Reviewer approved to Done May 28, 2020
@erisu erisu deleted the fix/remove-q-leftover branch May 29, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release Plan
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants