Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Properly set the WebView config when it is provided #1436

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented May 27, 2024

Platforms affected

iOS

Motivation and Context

Fixes GH-1423 (based on the comment on 4c81363#r142043240)

Description

Check that the engine class instance responds to the initWithFrame:configuration: selector rather than the engine class itself (because it's not a static class method).

Testing

All unit tests pass, but I don't think we have test coverage for this particular feature.

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

Sorry, something went wrong.

Closes apacheGH-1423.

Co-Authored-By: Michael Tamburro <61243400+msmtamburro@users.noreply.github.com>
@dpogue
Copy link
Member Author

dpogue commented May 27, 2024

/fyi @msmtamburro @Durzan666

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.35%. Comparing base (2240ebc) to head (93a95e6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1436   +/-   ##
=======================================
  Coverage   78.35%   78.35%           
=======================================
  Files          16       16           
  Lines        1825     1825           
=======================================
  Hits         1430     1430           
  Misses        395      395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dpogue dpogue added this to the 7.1.1 milestone May 28, 2024
@erisu erisu merged commit 9a7f676 into apache:master Jul 11, 2024
10 checks passed
@dpogue dpogue deleted the config-fix branch August 12, 2024 22:08
kntrs added a commit to dejiren/cordova-ios that referenced this pull request Aug 28, 2024
cordova-ios issue apache#1436 と同じ内容に手動で修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WKWebViewConfiguration is always ignored
3 participants