Hide splash sceen without SplashScreenDelay on .hide()
#1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make hiding of splash screen a race between `SplashScreenDelay` setting and navigator.splashscreen.hide(). Related issue: apache#991
|
Thanks for the PR @BendingBender! 🎉 This looks good with a quick skim over it, I'll take a more thorough look tomorrow. |
dpogue
approved these changes
Oct 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=======================================
Coverage 74.91% 74.91%
=======================================
Files 13 13
Lines 1718 1718
=======================================
Hits 1287 1287
Misses 431 431 Continue to review full report at Codecov.
|
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #991
Platforms affected
iOS
Motivation and Context
The
cordova-plugin-splash-screenallowed to hide the splash screen as a race between the timeout specified in theSplashScreenDelaypreference and the call tonavigator.splashscreen.hide()in JS code. This was very desirable, it allowed to show the splash screen for a long time if the application took a long time to boot but not too long so that users wouldn't think that the application is hanging.Since the reimplementation of this functionality here, the behavior has changed. Now, the
SplashScreenDelaypreference applies to calls made bynavigator.splashscreen.hide(), defeating the behavior described above.Description
Make hiding of splash screen again a race between the timeout specified in
SplashScreenDelaysetting andnavigator.splashscreen.hide()call.Testing
Manual tests in simulator and real device (iPhone X).
Checklist
I added automated test coverage as appropriate for this change- no idea, howCommit is prefixed with- doesn't make sense, this is a cordova-ios repo, it can only be ios-related(platform)if this change only applies to one platform (e.g.(android))