Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(run): call platform api to list targets #611

Merged
merged 1 commit into from
May 9, 2023

Conversation

erisu
Copy link
Member

@erisu erisu commented Apr 20, 2023

Platforms affected

n/a

Motivation and Context

Prepare for the removal of calling binaries in the platform packages.
Use the platform API to handle listing out of targets.

Description

This PR requires changes in apache/cordova-lib#917

Since this breaking change needs the braking changes from the aboves Cordova-Lib PR, it is unessary to call the old method.

Testing

npm t

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu added this to the 12.0.0 milestone Apr 20, 2023
@erisu erisu requested a review from dpogue April 20, 2023 13:30
@erisu erisu merged commit 32a2025 into apache:master May 9, 2023
9 checks passed
@erisu erisu deleted the feat/use-platform-api-target-list branch May 9, 2023 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants