Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: @cordova/eslint-config@^5.0.0 #118

Merged
merged 1 commit into from
May 2, 2023

Conversation

breautek
Copy link
Contributor

@breautek breautek commented May 2, 2023

Platforms affected

Browser

Motivation and Context

Upgrades eslint to our current configuration to maintain code standards.

Also upgrading also solves as a byproduct:

json5  <1.0.2
Severity: high
Prototype Pollution in JSON5 via Parse Method - https://github.com/advisories/GHSA-9c47-m6qq-7p4h

Description

Upgrade @cordova/eslint-config to 5.x and refactored necessary changes to comply with our lint rules.
Fixes were made mostly via eslint --fix argument.

Testing

Ran npm test.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@codecov-commenter
Copy link

Codecov Report

Merging #118 (6f2a39c) into master (3966de3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files           2        2           
  Lines          32       32           
=======================================
  Hits           30       30           
  Misses          2        2           
Impacted Files Coverage Δ
bin/lib/create.js 93.33% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@breautek breautek merged commit 529aba2 into apache:master May 2, 2023
9 checks passed
@breautek breautek deleted the refactor/eslint-config-upgrade branch May 2, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants