Fix generation for UUID type #60
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@weizhouapache @rohityadavcloud Please review. |
rohityadavcloud
requested review from
shwstppr,
mlsorensen,
Pearl1594 and
weizhouapache
| @@ -1291,7 +1291,7 @@ func (s *service) generateConvertCode(cmd, name, typ string) { | |||
| pn := s.pn | |||
|
|
|||
| switch typ { | |||
| case "string": | |||
| case "string", "UUID": | |||
There was a problem hiding this comment.
should it be UUID or uuid?
There was a problem hiding this comment.
We are explicitly setting it to "UUID" in L2096. As of now the value is UUID only for managementserverid. And uuid is being treated as a string. Changing this to uuid causes a lot of changes at other places and removes some helper functions.
https://github.com/apache/cloudstack-go/pull/60/files#diff-39a24c8d3907e38beb5e39b5f0a40df7aa73c38449615f140ec3fca502900e86L2096
This seems to be there because of this.
There was a problem hiding this comment.
Great thanks for checking @vishesh92
rohityadavcloud
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
managementserveridhas been added as a parameter in some APIs (listAsyncJobs,readyForShutdown, etc.) in 4.19. Generated output doesn't have the setters formanagementserveridfield intoURLValues()method.