[CALCITE-5748] Upgrade guava from 31.1-jre to 32.0.0-jre #3240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… CheckReturnValue check
|
Kudos, SonarCloud Quality Gate passed!
|
snuyanzin
changed the title
snuyanzin
commented
Jun 3, 2023
Comment on lines
-164
to
-169
| @SuppressWarnings("Guava") | ||
| @Deprecated // to be removed before 2.0 | ||
| public <T, R> Closeable addThread( | ||
| final com.google.common.base.Function<T, R> handler) { | ||
| return addThread((Consumer<T>) handler::apply); | ||
| } |
There was a problem hiding this comment.
With guava 32 it starts failing on errorprone checks with CheckReturnValue
Since it is already deprecated with a comment what to use instead probably it makes sense to remove it
snuyanzin
commented
Jun 3, 2023
Comment on lines
-1739
to
-1746
| // CHECKSTYLE: IGNORE 1 | ||
| /** @deprecated Use {@link #queryContains(Consumer)}. */ | ||
| @SuppressWarnings("Guava") | ||
| @Deprecated // to be removed before 2.0 | ||
| public final AssertQuery queryContains( | ||
| com.google.common.base.Function<List, Void> predicate1) { | ||
| return queryContains((Consumer<List>) predicate1::apply); | ||
| } |
There was a problem hiding this comment.
With guava 32 it starts failing on errorprone checks with CheckReturnValue
Since it is already deprecated with a comment what to use instead probably it makes sense to remove it
julianhyde
force-pushed
the
main
branch
2 times, most recently
from
8a5cf83
to
cf7f71b
Compare
|
closing, since the issue was solved in later guava versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regarding NPE on Windows it is just a consequence...
the real reason is fixing of CVE-2020-8908 on guava level[1] and as a result Files#createTempDir stopped working on Windows
I raised an issue for that [2]
Files#createTempDir is used inside embedded redis server and that's why it started to fail on Windows.
The most distracting thing is that this redis embedded server from one side looks not supported since 2018 and from the other side is not easily extensible...
For that reason need to reimplement 3 classes in PR to override behavior
[1] google/guava@feb83a1
[2] google/guava#6535