Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump cloud.google.com/go/pubsub from 1.24.0 to 1.25.0 in /sdks #22836

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 24, 2022

Bumps cloud.google.com/go/pubsub from 1.24.0 to 1.25.0.

Release notes

Sourced from cloud.google.com/go/pubsub's releases.

pubsub: v1.25.0

1.25.0 (2022-08-23)

Features

Documentation

storage: v1.25.0

1.25.0 (2022-08-11)

Features

  • storage/internal: Add routing annotations (8a8ba85)
  • storage: refactor to use transport-agnostic interface (#6465) (d03c3e1)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file go labels Aug 24, 2022
@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@dependabot dependabot bot force-pushed the dependabot/go_modules/sdks/cloud.google.com/go/pubsub-1.25.0 branch from cb6fdd1 to cf89ed0 Compare August 24, 2022 12:49
Bumps [cloud.google.com/go/pubsub](https://github.com/googleapis/google-cloud-go) from 1.24.0 to 1.25.0.
- [Release notes](https://github.com/googleapis/google-cloud-go/releases)
- [Changelog](https://github.com/googleapis/google-cloud-go/blob/main/CHANGES.md)
- [Commits](googleapis/google-cloud-go@pubsub/v1.24.0...pubsub/v1.25.0)

---
updated-dependencies:
- dependency-name: cloud.google.com/go/pubsub
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/sdks/cloud.google.com/go/pubsub-1.25.0 branch from cf89ed0 to 5ae406d Compare August 24, 2022 14:04
@lostluck lostluck self-requested a review August 24, 2022 18:02
@lostluck
Copy link
Contributor

Failing on build...

07:10:09 /home/jenkins/go/pkg/mod/cloud.google.com/go/pubsub@v1.25.0/message.go:109:26: undefined: pubsub.AckResult
07:10:09 /home/jenkins/go/pkg/mod/cloud.google.com/go/pubsub@v1.25.0/message.go:112:34: undefined: pubsub.AcknowledgeStatus
07:10:09 /home/jenkins/go/pkg/mod/cloud.google.com/go/pubsub@v1.25.0/iterator.go:553:13: undefined: pubsub.SetAckResult

But googleapis/google-cloud-go#6506 definitely adds the types and aliases them properly.

@lostluck
Copy link
Contributor

Run Go PreCommit

@damccorm
Copy link
Contributor

@damccorm
Copy link
Contributor

@dependabot recreate

@damccorm
Copy link
Contributor

^Not sure if that'll get it to pick up 1.25.1 which has the fix, if not we can manually do it

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Aug 24, 2022

Superseded by #22850.

@dependabot dependabot bot closed this Aug 24, 2022
@dependabot dependabot bot deleted the dependabot/go_modules/sdks/cloud.google.com/go/pubsub-1.25.0 branch August 24, 2022 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants