ARROW-5894: [Gandiva][C++] Added a linker script for libgandiva.so to restrict libstdc++ symbols. #4883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brills Does it still crash? I don't see anything on Travis. |
|
It's not with the latest commit which only hides the libstdc++ symbols. |
Codecov Report
@@ Coverage Diff @@
## master #4883 +/- ##
===========================================
- Coverage 87.42% 75.24% -12.19%
===========================================
Files 994 57 -937
Lines 140102 3708 -136394
Branches 1418 0 -1418
===========================================
- Hits 122481 2790 -119691
+ Misses 17259 918 -16341
+ Partials 362 0 -362Continue to review full report at Codecov.
|
kszucs
pushed a commit
that referenced
this pull request
Jul 22, 2019
… restrict libstdc++ symbols. I tried more aggressive restrictions that exports only *gandiva::* but unit tests crashed. (see the previous commit in this PR). Author: Zhuo Peng <1835738+brills@users.noreply.github.com> Closes #4883 from brills/linker-script and squashes the following commits: 67e1347 <Zhuo Peng> cmake format 778a194 <Zhuo Peng> Only restrict symbols from libstdc++ a8e0bac <Zhuo Peng> Added a linker script for Gandiva to limit exported symbols
pprudhvi
pushed a commit
to pprudhvi/arrow
that referenced
this pull request
Aug 11, 2019
… restrict libstdc++ symbols. I tried more aggressive restrictions that exports only *gandiva::* but unit tests crashed. (see the previous commit in this PR). Author: Zhuo Peng <1835738+brills@users.noreply.github.com> Closes apache#4883 from brills/linker-script and squashes the following commits: 67e1347 <Zhuo Peng> cmake format 778a194 <Zhuo Peng> Only restrict symbols from libstdc++ a8e0bac <Zhuo Peng> Added a linker script for Gandiva to limit exported symbols
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried more aggressive restrictions that exports only gandiva:: but unit tests crashed. (see the previous commit in this PR).