GH-41699: [Python][Parquet] Implement to_dict method on SortingColumn #41704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mapleFU
changed the title
|
|
|
Thank you for contributing! |
|
@AlenkaF Thanks for review! I have added it. |
AlenkaF
approved these changes
May 21, 2024
github-actions
bot
added
awaiting committer review
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b2e8c33. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
|
The benchmark regression seems to be momentary so we can ignore. |
vibhatha
pushed a commit
to vibhatha/arrow
that referenced
this pull request
May 25, 2024
…Column (apache#41704) ### Rationale for this change Resolves apache#41699 . ### What changes are included in this PR? Add `to_dict` method and test case ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#41699 Authored-by: Tai Le Manh <manhtai.lmt@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Resolves #41699 .
What changes are included in this PR?
Add
to_dictmethod and test caseAre these changes tested?
Yes
Are there any user-facing changes?
No