GH-39598: [C#] Fix verification script #39605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CurtHagenlocher
requested review from
assignUser,
kou and
raulcd
as code owners
|
|
raulcd
reviewed
Jan 15, 2024
| @@ -880,8 +880,8 @@ test_csharp() { | |||
| if [ "${SOURCE_KIND}" = "local" ]; then | |||
| echo "Skipping sourelink verification on local build" | |||
| else | |||
| dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb | |||
| dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netcoreapp3.1/Apache.Arrow.pdb | |||
| dotnet tool run sourcelink test artifacts/Apache.Arrow/Release/netstandard2.0/Apache.Arrow.pdb | |||
There was a problem hiding this comment.
I have no experience with C# and I might be saying something that doesn't make sense but is there a reason why we don't test this when SOURCE_KIND is local?
We probably could find the issue on nightlies / maintenance branch if we also tested there instead of only when we have generated a Release candidate.
There was a problem hiding this comment.
It seems that the skip was added by #33799.
@westonpace Do you remember why you disabled the sourcelink check when SOURCE_KIND is local?
raulcd
reviewed
Jan 15, 2024
| @@ -880,8 +880,8 @@ test_csharp() { | |||
| if [ "${SOURCE_KIND}" = "local" ]; then | |||
| echo "Skipping sourelink verification on local build" | |||
There was a problem hiding this comment.
Found a minor typo:
Suggested change
| echo "Skipping sourelink verification on local build" | |
| echo "Skipping sourcelink verification on local build" |
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
raulcd
approved these changes
Jan 16, 2024
github-actions
bot
added
awaiting merge
raulcd
pushed a commit
that referenced
this pull request
Jan 16, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: #39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit d6a8305. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
idailylife
pushed a commit
to idailylife/arrow
that referenced
this pull request
Jan 18, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: apache#39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
clayburn
pushed a commit
to clayburn/arrow
that referenced
this pull request
Jan 23, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: apache#39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: apache#39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
zanmato1984
pushed a commit
to zanmato1984/arrow
that referenced
this pull request
Feb 28, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: apache#39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### What changes are included in this PR? The verification script is modified to look for the versions of .NET now supported by the package. ### Are these changes tested? Manually tested the verification command. * Closes: apache#39598 Authored-by: Curt Hagenlocher <curt@hagenlocher.org> Signed-off-by: Curt Hagenlocher <curt@hagenlocher.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are included in this PR?
The verification script is modified to look for the versions of .NET now supported by the package.
Are these changes tested?
Manually tested the verification command.
file does not exist: artifacts/Apache.Arrow/Release/netstandard1.3/Apache.Arrow.pdb#39598