Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM #35023

Merged
merged 4 commits into from
Apr 12, 2023
Merged

GH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM #35023

merged 4 commits into from
Apr 12, 2023

Conversation

kou
Copy link
Member

@kou kou commented Apr 11, 2023 •
edited by github-actions bot

Rationale for this change

LLVM may use Zstandard. For example llvm@15 in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when ARROW_ZSTD_USE_SHARED is OFF.

What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect ARROW_ZSTD_USE_SHARED.

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

@kou
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM
7035e7d 
LLVM may use Zstandard. For example `llvm@15` in Homebrew uses
Zstandard. LLVM finds Zstandared by itself. So libzstd.dylib may be
used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

This change adjusts Zstandared used by LLVM to reflect
`ARROW_ZSTD_USE_SHARED`.
@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #35018 has been automatically assigned in GitHub to PR creator.

@kou
Copy link
Member Author

kou commented Apr 11, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 7035e7d

Submitted crossbow builds: ursacomputing/crossbow @ actions-116b05aaca

Task Status
java-jars Github Actions

@kou
Copy link
Member Author

kou commented Apr 11, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 7a2640f

Submitted crossbow builds: ursacomputing/crossbow @ actions-730b028f4a

Task Status
java-jars Github Actions

@kou
Copy link
Member Author

kou commented Apr 11, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: ad63ab0

Submitted crossbow builds: ursacomputing/crossbow @ actions-75d7a04a11

Task Status
java-jars Github Actions

@kou
Copy link
Member Author

kou commented Apr 12, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 8214f13

Submitted crossbow builds: ursacomputing/crossbow @ actions-0b00070430

Task Status
java-jars Github Actions

@kou
Copy link
Member Author

kou commented Apr 12, 2023

+1

The Zstandard problem is solved but there is another problem: #35086
The another problem should be handled in another task.

@kou kou merged commit 0434ab6 into apache:main Apr 12, 2023
27 of 30 checks passed
@kou kou deleted the java-jni-llvm-static branch April 12, 2023 20:46
@ursabot
Copy link

ursabot commented Apr 15, 2023

Benchmark runs are scheduled for baseline = c2904b0 and contender = 0434ab6. 0434ab6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed] test-mac-arm
[Finished ⬇️15.56% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.22% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 0434ab65 ec2-t3-xlarge-us-east-2
[Failed] 0434ab65 test-mac-arm
[Finished] 0434ab65 ursa-i9-9960x
[Finished] 0434ab65 ursa-thinkcentre-m75q
[Finished] c2904b0b ec2-t3-xlarge-us-east-2
[Failed] c2904b0b test-mac-arm
[Finished] c2904b0b ursa-i9-9960x
[Finished] c2904b0b ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Apr 15, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

@raulcd raulcd mentioned this pull request Apr 18, 2023
Closed
liujiacheng777 pushed a commit to LoongArch-Python/arrow that referenced this pull request May 11, 2023
@kou @liujiacheng777
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
b62e33f 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
ArgusLi pushed a commit to Bit-Quill/arrow that referenced this pull request May 15, 2023
@kou @ArgusLi
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
7d7c1cf 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
rtpsw pushed a commit to rtpsw/arrow that referenced this pull request May 16, 2023
@kou @rtpsw
apacheGH-35018: [CI][Java][C++] Use ARROW_ZSTD_USE_SHARED=OFF for LLVM (
8737445 
apache#35023)

### Rationale for this change

LLVM may use Zstandard. For example `llvm@ 15` in Homebrew uses Zstandard. LLVM finds
Zstandared by itself. So libzstd.dylib may be used even when `ARROW_ZSTD_USE_SHARED` is `OFF`.

### What changes are included in this PR?

This change adjusts Zstandared used by LLVM to reflect `ARROW_ZSTD_USE_SHARED`.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#35018

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting committer review Awaiting committer review Component: C++ - Gandiva Component: C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI][Java] Build C++ libraries macOS x86_64 Failing
2 participants
@kou @ursabot