Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-33723: [C++] re2::RE2::RE2() result must be checked #33781

Closed
wants to merge 1 commit into from
Closed

GH-33723: [C++] re2::RE2::RE2() result must be checked #33781

wants to merge 1 commit into from

Conversation

Ziy1-Tan
Copy link

@Ziy1-Tan Ziy1-Tan commented Jan 19, 2023

Rationale for this change

closes #33723

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

@github-actions
Copy link

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

@Ziy1-Tan
Copy link
Author

cc @kou

@lidavidm lidavidm changed the title re2::RE2::RE2() result must be checked GH-33723: [C++] re2::RE2::RE2() result must be checked Jan 19, 2023
@github-actions
Copy link

@kou
Copy link
Member

kou commented Jan 21, 2023

Thanks! But #33806 is better approach.
I close this in favor of #33806.

@kou kou closed this Jan 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[C++] re2::RE2::RE2() result must be checked
2 participants