Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-33754: [CI] Install brewfile dependencies for verification task jobs on M1 #33755

Merged
merged 1 commit into from
Jan 19, 2023

Conversation

raulcd
Copy link
Member

@raulcd raulcd commented Jan 18, 2023

Rationale for this change

This should fix the verification job failures for M1

What changes are included in this PR?

The PR ensure installation of our defined Brewfile dependencies as part of the verification tasks

Are these changes tested?

Will be tested via crossbow tasks

Are there any user-facing changes?

No

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #33754 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member Author

raulcd commented Jan 18, 2023

@github-actions crossbow submit verify-rc-source-*-macos-arm64

@github-actions
Copy link

Revision: 3be10f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-1023b2ca9a

Task Status
verify-rc-source-cpp-macos-arm64 Github Actions
verify-rc-source-csharp-macos-arm64 Github Actions
verify-rc-source-go-macos-arm64 Github Actions
verify-rc-source-integration-macos-arm64 Github Actions
verify-rc-source-js-macos-arm64 Github Actions
verify-rc-source-python-macos-arm64 Github Actions
verify-rc-source-ruby-macos-arm64 Github Actions

@raulcd
Copy link
Member Author

raulcd commented Jan 18, 2023

@kou this seems to fix the issue. As this is only because of our M1's setup I don't think it requires a new RC for 11.0.0 to be created. We should probably back-port it to the maintenance branch in case a new RC is required or we do a 11.0.1 release in the future.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

I think so too.

@kou kou merged commit ebf6620 into apache:master Jan 19, 2023
@ursabot
Copy link

ursabot commented Jan 20, 2023

Benchmark runs are scheduled for baseline = fb264b7 and contender = ebf6620. ebf6620 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️2.37% ⬆️0.06%] test-mac-arm
[Finished ⬇️1.28% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.09% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] ebf66201 ec2-t3-xlarge-us-east-2
[Failed] ebf66201 test-mac-arm
[Finished] ebf66201 ursa-i9-9960x
[Finished] ebf66201 ursa-thinkcentre-m75q
[Finished] fb264b77 ec2-t3-xlarge-us-east-2
[Failed] fb264b77 test-mac-arm
[Finished] fb264b77 ursa-i9-9960x
[Finished] fb264b77 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented Jan 20, 2023

['Python', 'R'] benchmarks have high level of regressions.
test-mac-arm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI][C++] macOS arm64 verification tasks fail due to missing grpc++ headers
3 participants