GH-14997: [Release] Ensure archery release tasks works with both new style GitHub issues and old style JIRA issues #33615
Conversation
|
This is an example of how the new changelog for 11.0.0 will look with a mix of issues from JIRA and GITHUB: https://gist.github.com/raulcd/1eebbfc28e890d9abbb248db48ba5775 |
raulcd
changed the title
| def is_pr(self): | ||
| return bool(self._github_issue and self._github_issue.pull_request) |
There was a problem hiding this comment.
It seems that self._github_issue is needed only for this. How about setting self.is_pr instead of keeping self._github_issue?
There was a problem hiding this comment.
I do prefer to keep the github_issue cached on our Issue when available (not for PARQUET) so if we need other things in the future like, components, the PR associated, the sha commit of the merge, etcetera we already have that available.
There was a problem hiding this comment.
I see. I don't object it.
FYI: Reusing this class for Jira issue may not be a good idea. If I implement this, I'll define GitHubIssue(Issue) and JiraIssue(Issue) and JiraIssue.is_pr always returns False.
|
The linting error is coming from master and has been merged there already: |
| def is_pr(self): | ||
| return bool(self._github_issue and self._github_issue.pull_request) |
There was a problem hiding this comment.
I see. I don't object it.
FYI: Reusing this class for Jira issue may not be a good idea. If I implement this, I'll define GitHubIssue(Issue) and JiraIssue(Issue) and JiraIssue.is_pr always returns False.
…oth GitHub and old Apache Arrow JIRA issues
…GitHub instead of JIRA
…igrated issues from JIRA
|
Style issue: when reading "Archery release tasks takes into account both GitHub and old Apache Arrow JIRA issues", we don't know whether that's describing the situation pre-PR or post-PR. To fix this, it is preferrable to use an infinitive to describe what the PR does. For example: "Ensure that Archery release tasks work with both ...". @wjones127 for suggestions |
raulcd
changed the title
|
Benchmark runs are scheduled for baseline = c8d6110 and contender = 4e439f6. 4e439f6 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
I've decided to do all the archery release tasks on a single PR: