-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-14482: [C++][Gandiva] Implement MASK_FIRST_N and MASK_LAST_N functions #11551
ARROW-14482: [C++][Gandiva] Implement MASK_FIRST_N and MASK_LAST_N functions #11551
Conversation
|
079d0a1
to
aae056a
Compare
b55ec65
to
8787053
Compare
8787053
to
29bd8b2
Compare
@augustoasilva There was two failures in one of the C++ tests here. can you please fix that ? [ RUN ] TestGdvFnStubs.TestMaskFirstN==18940==ERROR: AddressSanitizer: global-buffer-overflow on address 0x0000009442fd at pc 0x00000053b039 bp 0x7fff1703f740 sp 0x7fff1703eef0 [ RUN ] TestProjector.TestMaskFirstMaskLastN |
@pravindra Can you aprove again to see if those errors where fixed? |
@augustoasilva Can you hold on this? I'd like to understand how the Hive UDF works with non-ascii input |
@vvellanki Sure, I will hold this one. |
16c47f5
to
9a839d1
Compare
4683cc8
to
a4a07c5
Compare
65b6fe6
to
faab313
Compare
b8f9b52
to
0ceb879
Compare
c9fbd60
to
8f9b671
Compare
Benchmark runs are scheduled for baseline = 08e044f and contender = 00d5077. 00d5077 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
MASK_FIRST_N
Returns a masked version of str with the first n values masked. Upper case letters are converted to "X", lower case letters are converted to "x" and numbers are converted to "n". For example, mask_first_n("1234-5678-8765-4321", 4) results in nnnn-5678-8765-4321.
MASK_LAST_N
Returns a masked version of str with the last n values masked. Upper case letters are converted to "X", lower case letters are converted to "x" and numbers are converted to "n". For example, mask_last_n("1234-5678-8765-4321", 4) results in 1234-5678-8765-nnnn.