-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-41699: [Python][Parquet] Implement to_dict method on SortingColumn #41704
Conversation
|
|
Thank you for contributing! |
@AlenkaF Thanks for review! I have added it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor nit otherwise LGTM. Thanks!
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
Signed-off-by: Tai Le Manh <manhtai.lmt@gmail.com>
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit b2e8c33. There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. It also includes information about 10 possible false positives for unstable benchmarks that are known to sometimes produce them. |
The benchmark regression seems to be momentary so we can ignore. |
…Column (apache#41704) ### Rationale for this change Resolves apache#41699 . ### What changes are included in this PR? Add `to_dict` method and test case ### Are these changes tested? Yes ### Are there any user-facing changes? No * GitHub Issue: apache#41699 Authored-by: Tai Le Manh <manhtai.lmt@gmail.com> Signed-off-by: AlenkaF <frim.alenka@gmail.com>
Rationale for this change
Resolves #41699 .
What changes are included in this PR?
Add
to_dict
method and test caseAre these changes tested?
Yes
Are there any user-facing changes?
No