GH-40386: [Python] Fix except clauses #40387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
felipecrv
approved these changes
Mar 6, 2024
|
After merging your PR, Conbench analyzed the 7 benchmarking runs that have been run so far on merge-commit 1d966e9. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 4 possible false positives for unstable benchmarks that are known to sometimes produce them. |
mapleFU
pushed a commit
to mapleFU/arrow
that referenced
this pull request
Mar 7, 2024
### Rationale for this change See apache#40386, these changes are necessary for compatibility with Cython 3.0.9 ### What changes are included in this PR? This PR removes unnecessary `noexcept` clauses. ### Are these changes tested? Covered by existing builds. ### Are there any user-facing changes? No. * GitHub Issue: apache#40386 Authored-by: Vyas Ramasubramani <vyasr@nvidia.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Mar 8, 2024
### Rationale for this change See apache#40386, these changes are necessary for compatibility with Cython 3.0.9 ### What changes are included in this PR? This PR removes unnecessary `noexcept` clauses. ### Are these changes tested? Covered by existing builds. ### Are there any user-facing changes? No. * GitHub Issue: apache#40386 Authored-by: Vyas Ramasubramani <vyasr@nvidia.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
raulcd
pushed a commit
that referenced
this pull request
Mar 12, 2024
### Rationale for this change See #40386, these changes are necessary for compatibility with Cython 3.0.9 ### What changes are included in this PR? This PR removes unnecessary `noexcept` clauses. ### Are these changes tested? Covered by existing builds. ### Are there any user-facing changes? No. * GitHub Issue: #40386 Authored-by: Vyas Ramasubramani <vyasr@nvidia.com> Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
See #40386, these changes are necessary for compatibility with Cython 3.0.9
What changes are included in this PR?
This PR removes unnecessary
noexceptclauses.Are these changes tested?
Covered by existing builds.
Are there any user-facing changes?
No.