Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Python] Python build was broken by Cython 3.0.9 #40386

Closed
vyasr opened this issue Mar 6, 2024 · 5 comments
Closed

[Python] Python build was broken by Cython 3.0.9 #40386

vyasr opened this issue Mar 6, 2024 · 5 comments
Assignees
@vyasr
Labels
Component: Python Type: bug
Milestone
15.0.2

Comments

@vyasr
Copy link
Contributor

vyasr commented Mar 6, 2024

Describe the bug, including details regarding any error messages, version, and platform.

The Cython 3.0.9 release yesterday (3/5/24) added a warning when a Cython function is marked noexcept while returning a Python object. This appears to have broken builds of pyarrow (see recent runs on #40373). I glanced at pyarrow's setup.py and it wasn't immediately obvious clear where/if pyarrow is setting warnings as errors for Cython, but I assume it is doing so if it's breaking the build.

Component(s)

Python
@vyasr vyasr added the Type: bug label Mar 6, 2024
@vyasr vyasr mentioned this issue Mar 6, 2024
Merged
@vyasr vyasr mentioned this issue Mar 6, 2024
Merged
@kou kou changed the title Python build was broken by Cython 3.0.9 [Python] Python build was broken by Cython 3.0.9 Mar 6, 2024
@austin3dickey
Copy link
Contributor

Note that this is causing all benchmarking builds to fail as well (causing messages like #40367 (comment))

@kou
Copy link
Member

kou commented Mar 6, 2024

Duplicated of #40375.

@kou kou closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2024
felipecrv pushed a commit that referenced this issue Mar 6, 2024
@vyasr
GH-40386: [Python] Fix except clauses (#40387)
1d966e9 
### Rationale for this change

See #40386, these changes are necessary for compatibility with Cython 3.0.9

### What changes are included in this PR?

This PR removes unnecessary `noexcept` clauses.

### Are these changes tested?

Covered by existing builds.

### Are there any user-facing changes?

No.

* GitHub Issue: #40386

Authored-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@felipecrv felipecrv mentioned this issue Mar 6, 2024
Closed
mapleFU pushed a commit to mapleFU/arrow that referenced this issue Mar 7, 2024
@vyasr @mapleFU
apacheGH-40386: [Python] Fix except clauses (apache#40387)
5ec63fd 
### Rationale for this change

See apache#40386, these changes are necessary for compatibility with Cython 3.0.9

### What changes are included in this PR?

This PR removes unnecessary `noexcept` clauses.

### Are these changes tested?

Covered by existing builds.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#40386

Authored-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@jorisvandenbossche jorisvandenbossche added this to the 15.0.1 milestone Mar 7, 2024
@jorisvandenbossche
Copy link
Member

Closed by #40387

@jorisvandenbossche
Copy link
Member

I glanced at pyarrow's setup.py and it wasn't immediately obvious clear where/if pyarrow is setting warnings as errors for Cython, but I assume it is doing so if it's breaking the build.

Small follow-up, we indeed do that here:

arrow/python/CMakeLists.txt

Lines 722 to 723 in 49cdb0f

# Error on any warnings not already explicitly ignored.
set(CYTHON_FLAGS "${CYTHON_FLAGS}" "--warning-errors")

(I was wondering myself as well ;))

And thanks for the PR!

@vyasr
Copy link
Contributor Author

vyasr commented Mar 8, 2024

Aha I didn't realize it was building with CMake using a custom setuptools command setup.

My follow-up was going to be if you'd considered using scikit-build, but it looks like there's already discussion of that in #36411!

thisisnic pushed a commit to thisisnic/arrow that referenced this issue Mar 8, 2024
@vyasr @thisisnic
apacheGH-40386: [Python] Fix except clauses (apache#40387)
3b86b08 
### Rationale for this change

See apache#40386, these changes are necessary for compatibility with Cython 3.0.9

### What changes are included in this PR?

This PR removes unnecessary `noexcept` clauses.

### Are these changes tested?

Covered by existing builds.

### Are there any user-facing changes?

No.

* GitHub Issue: apache#40386

Authored-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@raulcd raulcd modified the milestones: 15.0.1, 15.0.2 Mar 12, 2024
raulcd pushed a commit that referenced this issue Mar 12, 2024
@vyasr @raulcd
GH-40386: [Python] Fix except clauses (#40387)
a6cabb2 
### Rationale for this change

See #40386, these changes are necessary for compatibility with Cython 3.0.9

### What changes are included in this PR?

This PR removes unnecessary `noexcept` clauses.

### Are these changes tested?

Covered by existing builds.

### Are there any user-facing changes?

No.

* GitHub Issue: #40386

Authored-by: Vyas Ramasubramani <vyasr@nvidia.com>
Signed-off-by: Felipe Oliveira Carvalho <felipekde@gmail.com>
@austin3dickey austin3dickey mentioned this issue Mar 12, 2024
Merged
@raulcd raulcd mentioned this issue Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vyasr vyasr

Labels
Component: Python Type: bug
Projects
None yet
Milestone
15.0.2
Development

No branches or pull requests
5 participants
@kou @raulcd @jorisvandenbossche @vyasr @austin3dickey