GH-38449: [Release][Go][macOS] Use local test data if possible #38450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a"). We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".
|
|
|
@github-actions crossbow submit verify-rc-source-go-* --param release=14.0.0 --param rc=2 |
|
Revision: b8090a6 Submitted crossbow builds: ursacomputing/crossbow @ actions-6a647948aa
|
raulcd
approved these changes
Oct 25, 2023
JerAguilon
pushed a commit
to JerAguilon/arrow
that referenced
this pull request
Oct 25, 2023
…pache#38450) ### Rationale for this change On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a"). ### What changes are included in this PR? We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/". ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38449 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
|
After merging your PR, Conbench analyzed the 5 benchmarking runs that have been run so far on merge-commit 25e5d19. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
loicalleyne
pushed a commit
to loicalleyne/arrow
that referenced
this pull request
Nov 13, 2023
…pache#38450) ### Rationale for this change On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a"). ### What changes are included in this PR? We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/". ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38449 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
raulcd
pushed a commit
that referenced
this pull request
Dec 12, 2023
### Rationale for this change On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a"). ### What changes are included in this PR? We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/". ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: #38449 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
dgreiss
pushed a commit
to dgreiss/arrow
that referenced
this pull request
Feb 19, 2024
…pache#38450) ### Rationale for this change On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a"). ### What changes are included in this PR? We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/". ### Are these changes tested? Yes. ### Are there any user-facing changes? No. * Closes: apache#38449 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").
What changes are included in this PR?
We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".
Are these changes tested?
Yes.
Are there any user-facing changes?
No.