Skip to content

Commit

Permalink
GH-38449: [Release][Go][macOS] Use local test data if possible (#38450)
Browse files Browse the repository at this point in the history
### Rationale for this change

On macOS, "cp -a source/ destination/" copies "source/*" to "destination/" (such as "source/a" is copied to "destination/a") not "source/" to "destination/" (such as "source/a" is copied to "destination/source/a").

### What changes are included in this PR?

We need to remove the trailing "/" from "source/" to copy "source/" itself to "destination/source/".

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #38449

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
  • Loading branch information
kou authored and raulcd committed Dec 12, 2023
1 parent 7a54881 commit 8fc81ce
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dev/release/verify-release-candidate.sh
Original file line number Diff line number Diff line change
Expand Up @@ -962,7 +962,7 @@ ensure_source_directory() {
# Ensure that the testing repositories are prepared
if [ ! -d ${ARROW_SOURCE_DIR}/testing/data ]; then
if [ -d ${SOURCE_DIR}/../../testing/data ]; then
cp -a ${SOURCE_DIR}/../../testing/ ${ARROW_SOURCE_DIR}/
cp -a ${SOURCE_DIR}/../../testing ${ARROW_SOURCE_DIR}/
else
git clone \
https://github.com/apache/arrow-testing.git \
Expand All @@ -972,7 +972,7 @@ ensure_source_directory() {
if [ ! -d ${ARROW_SOURCE_DIR}/cpp/submodules/parquet-testing/data ]; then
if [ -d ${SOURCE_DIR}/../../cpp/submodules/parquet-testing/data ]; then
cp -a \
${SOURCE_DIR}/../../cpp/submodules/parquet-testing/ \
${SOURCE_DIR}/../../cpp/submodules/parquet-testing \
${ARROW_SOURCE_DIR}/cpp/submodules/
else
git clone \
Expand Down

0 comments on commit 8fc81ce

Please sign in to comment.