Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][C++] macOS arm64 verification tasks fail due to missing grpc++ headers #33754

Closed
raulcd opened this issue Jan 18, 2023 · 4 comments · Fixed by #33755
Closed

[CI][C++] macOS arm64 verification tasks fail due to missing grpc++ headers #33754

raulcd opened this issue Jan 18, 2023 · 4 comments · Fixed by #33755

Comments

@raulcd
Copy link
Member

raulcd commented Jan 18, 2023

Describe the bug, including details regarding any error messages, version, and platform.

Since yesterday the nightlies for macOS arm64:
verify-rc-source-cpp-macos-arm64
verify-rc-source-integration-macos-arm64

have failed with:

 -- Forcing gRPC_SOURCE to Protobuf_SOURCE (SYSTEM)
CMake Warning at cmake_modules/FindgRPCAlt.cmake:25 (find_package):
  By not providing "FindgRPC.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "gRPC", but
  CMake did not find one.

  Could not find a package configuration file provided by "gRPC" (requested
  version 1.17.0) with any of the following names:

    gRPCConfig.cmake
    grpc-config.cmake

  Add the installation prefix of "gRPC" to CMAKE_PREFIX_PATH or set
  "gRPC_DIR" to a directory containing one of the above files.  If "gRPC"
  provides a separate development package or SDK, be sure it has been
  installed.
Call Stack (most recent call first):
  cmake_modules/ThirdpartyToolchain.cmake:280 (find_package)
  cmake_modules/ThirdpartyToolchain.cmake:3942 (resolve_dependency)
  CMakeLists.txt:498 (include)


-- Checking for module 'grpc++'
--   No package 'grpc++' found
-- Providing CMake module for gRPCAlt as part of Arrow CMake package
-- pkg-config package for grpc++ for static link isn't found
CMake Error at cmake_modules/ThirdpartyToolchain.cmake:3957 (get_target_property):
  get_target_property() called with non-existent target "gRPC::grpc++".
Call Stack (most recent call first):
  CMakeLists.txt:498 (include)


CMake Error at cmake_modules/ThirdpartyToolchain.cmake:3965 (message):
  Cannot find grpc++ headers in
Call Stack (most recent call first):
  CMakeLists.txt:498 (include)


-- Configuring incomplete, errors occurred!
See also "/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.2O9roRLY/cpp-build/CMakeFiles/CMakeOutput.log".
See also "/var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.2O9roRLY/cpp-build/CMakeFiles/CMakeError.log".
Failed to verify release candidate. See /var/folders/dl/2sqc_b2s20vfy540jn97pz8h0000gn/T/arrow-HEAD.XXXXX.2O9roRLY for details.

This have also failed on the Release Candidate 0 verification tasks for 11.0.0:
#33751 (comment)

Component(s)

C++, Continuous Integration

@raulcd
Copy link
Member Author

raulcd commented Jan 18, 2023

@kou could this be a side effect of the brew uninstall grpc here #33711 ?

@kou
Copy link
Member

kou commented Jan 18, 2023

I think so.
Our self-hosted arm64 runner isn't ephemeral. I think that we should install grpc formula explicitly in a job that needs grpc formula.

@kou
Copy link
Member

kou commented Jan 18, 2023

The following patch may work:

diff --git a/dev/tasks/verify-rc/github.macos.arm64.yml b/dev/tasks/verify-rc/github.macos.arm64.yml
index 79cdf4479e..a875c7c224 100644
--- a/dev/tasks/verify-rc/github.macos.arm64.yml
+++ b/dev/tasks/verify-rc/github.macos.arm64.yml
@@ -43,6 +43,8 @@ jobs:
           TEST_DEFAULT: 0
           TEST_{{ target|upper }}: 1
         run: |
+          brew bundle --file=cpp/Brewfile
+          brew bundle --file=c_glib/Brewfile
           export PATH="$(brew --prefix node@16)/bin:$PATH"
           export PATH="$(brew --prefix ruby)/bin:$PATH"
           export PKG_CONFIG_PATH="$(brew --prefix ruby)/lib/pkgconfig"

@raulcd
Copy link
Member Author

raulcd commented Jan 18, 2023

I'll try a PR

raulcd added a commit to raulcd/arrow that referenced this issue Jan 18, 2023
kou pushed a commit that referenced this issue Jan 19, 2023
…bs on M1 (#33755)

### Rationale for this change

This should fix the verification job failures for M1

### What changes are included in this PR?

The PR ensure installation of our defined `Brewfile` dependencies as part of the verification tasks

### Are these changes tested?

Will be tested via crossbow tasks

### Are there any user-facing changes?

No
* Closes: #33754

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
@kou kou added this to the 12.0.0 milestone Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants