Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-25633: [CI][Java][macOS] Ensure using bundled RE2 #33711

Merged
merged 2 commits into from Jan 17, 2023
Merged

GH-25633: [CI][Java][macOS] Ensure using bundled RE2 #33711

merged 2 commits into from Jan 17, 2023

Conversation

kou
Copy link
Member

@kou kou commented Jan 17, 2023 •
edited by github-actions bot

Rationale for this change

If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and bundled RE2.
If we mix re2.h and libre2.a, we may generate wrong re2::RE2::Options. It may crashes our program.

What changes are included in this PR?

Ensure removing Homebrew's RE2.

Are these changes tested?

Yes.

Are there any user-facing changes?

No.

@kou
apacheGH-25633: [CI][Java][macOS] Ensure using bundled RE2
547a127 
If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and
bundled RE2. If we mix re2.h and libre2.a, we may generate wrong
re2::RE2::Options. It may crashes our program.
@kou
Copy link
Member Author

kou commented Jan 17, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

@github-actions
Copy link

⚠️ GitHub issue #25633 has been automatically assigned in GitHub to PR creator.

@github-actions
Copy link

Revision: 547a127

Submitted crossbow builds: ursacomputing/crossbow @ actions-15715d7ab8

Task Status
java-jars Github Actions

assignUser
assignUser approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@assignUser assignUser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 awesome, thanks @kou I will merge once the CB job is green!

@kou
Copy link
Member Author

kou commented Jan 17, 2023

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: 28e221e

Submitted crossbow builds: ursacomputing/crossbow @ actions-c094071131

Task Status
java-jars Github Actions

@assignUser assignUser merged commit eae79e7 into apache:master Jan 17, 2023
@kou kou deleted the ci-java-jars-macos-arm64 branch January 17, 2023 04:34
@ursabot
Copy link

ursabot commented Jan 17, 2023

Benchmark runs are scheduled for baseline = fa59051 and contender = eae79e7. eae79e7 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.39% ⬆️0.09%] test-mac-arm
[Finished ⬇️0.0% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.25% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] eae79e7e ec2-t3-xlarge-us-east-2
[Finished] eae79e7e test-mac-arm
[Finished] eae79e7e ursa-i9-9960x
[Finished] eae79e7e ursa-thinkcentre-m75q
[Finished] fa590511 ec2-t3-xlarge-us-east-2
[Finished] fa590511 test-mac-arm
[Finished] fa590511 ursa-i9-9960x
[Finished] fa590511 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

raulcd pushed a commit that referenced this pull request Jan 18, 2023
@kou @raulcd
GH-25633: [CI][Java][macOS] Ensure using bundled RE2 (#33711)
5bda66a 
### Rationale for this change

If we have Homebrew's RE2, we may mix re2.h from Homebrew's RE2 and bundled RE2.
If we mix re2.h and libre2.a, we may generate wrong re2::RE2::Options. It may crashes our program.

### What changes are included in this PR?

Ensure removing Homebrew's RE2.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* Closes: #25633

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
@raulcd raulcd mentioned this pull request Jan 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@assignUser assignUser assignUser approved these changes

@raulcd raulcd Awaiting requested review from raulcd

Assignees
No one assigned
Labels
Component: Continuous Integration Component: Java
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI][C++][Java] Gandiva tests cause java-jars nightly to fail
3 participants
@kou @ursabot @assignUser