New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R] Two tests are failing with to-be-released dplyr dependency #33666
Comments
Should this be a blocker? We could cherry pick it into the cran release but eh |
It would be nice to not have to cherry pick! I think this one is a quick. There's also an LTO nightly failure that's probably an arrow C++ problem (also probably a quick fix). |
Marked as blocker as worst case it will necessitate another CRAN release |
@paleolimbot Where did you spot the second test failure? I couldn't reproduce it locally after installing dev dplyr. |
I believe that's because I hadn't installed the latest lubridate on my laptop. We don't have to have our tests pass for outdated lubridate so feel free to ignore it! |
This PR removes the `keep` argument from the test for `semi_join()`, which are causing the unit tests to fail. It also removes the argument `suffix` argument (which is not part of the dplyr function signature) from the function signature here. Closes: #33666 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
This PR removes the `keep` argument from the test for `semi_join()`, which are causing the unit tests to fail. It also removes the argument `suffix` argument (which is not part of the dplyr function signature) from the function signature here. Closes: #33666 Authored-by: Nic Crane <thisisnic@gmail.com> Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
Describe the bug, including details regarding any error messages, version, and platform.
(Looks like we just need to remove
keep = TRUE
, which was never an argument tosemi_join()
anyway?)Component(s)
R
The text was updated successfully, but these errors were encountered: