Skip to content

Commit

Permalink
GH-33666: [R] Remove extraneous argument to semi_join (#33693)
Browse files Browse the repository at this point in the history
This PR removes the `keep` argument from the test for `semi_join()`, which are causing the unit tests to fail.  It also removes the argument `suffix` argument (which is not part of the dplyr function signature) from the function signature here.

Closes: #33666

Authored-by: Nic Crane <thisisnic@gmail.com>
Signed-off-by: Dewey Dunnington <dewey@fishandwhistle.net>
  • Loading branch information
thisisnic committed Jan 17, 2023
1 parent bff9e5e commit fa59051
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions r/tests/testthat/test-dplyr-join.R
Expand Up @@ -82,7 +82,7 @@ test_that("left_join with join_by", {
left_join(
to_join %>%
rename(the_grouping = some_grouping),
join_by(some_grouping == the_grouping)
join_by(some_grouping == the_grouping)
) %>%
collect(),
left
Expand Down Expand Up @@ -240,14 +240,7 @@ test_that("full_join", {
test_that("semi_join", {
compare_dplyr_binding(
.input %>%
semi_join(to_join, by = "some_grouping", keep = TRUE) %>%
collect(),
left
)

compare_dplyr_binding(
.input %>%
semi_join(to_join, by = "some_grouping", keep = FALSE) %>%
semi_join(to_join, by = "some_grouping") %>%
collect(),
left
)
Expand Down

0 comments on commit fa59051

Please sign in to comment.