Remove read_csv_arrow parameters which are not implemented for datase…

…ts, and add docs

r/NAMESPACE

@@ -348,6 +348,7 @@ export(new_extension_type)
 export(null)
 export(num_range)
 export(one_of)
+export(open_csv_dataset)
 export(open_dataset)
 export(read_csv_arrow)
 export(read_delim_arrow)

r/R/dataset.R

@@ -228,6 +228,14 @@ open_dataset <- function(sources,
   )
 }
 
+#' Open a multi-file dataset of CSVs
+#'
+#' A wrapper around [open_dataset] which explicitly includes parameters specific to reading CSV files
+#'
+#' @inheritParams open_dataset
+#' @inheritParams read_csv_arrow
+#'
+#' @export
 open_csv_dataset <- function(sources,
                              schema = NULL,
                              partitioning = hive_partition(),
@@ -240,33 +248,11 @@ open_csv_dataset <- function(sources,
                              escape_backslash = FALSE,
                              col_names = TRUE,
                              col_types = NULL,
-                             col_select = NULL,
-                             na = NULL,
-                             quoted_na = NULL,
                              skip_empty_rows = TRUE,
                              skip = 0L,
-                             parse_options = NULL,
                              convert_options = NULL,
                              read_options = NULL,
-                             as_data_frame = TRUE,
                              timestamp_parsers = NULL) {
-browser()
-  if (!is.null(col_select)) {
-    abort('The following options are supported in "read_delim_arrow" functions but not yet supported here: "col_select"')
-  }
-
-  if (!is.null(na)) {
-    abort('The following options are supported in "read_delim_arrow" functions but not yet supported here: "na"')
-  }
-
-  if (!is.null(quoted_na)) {
-    abort('The following options are supported in "read_delim_arrow" functions but not yet supported here: "quoted_na"')
-  }
-
-  if (!is.null(parse_options)) {
-    abort('The following options are supported in "read_delim_arrow" functions but not yet supported here: "parse_options"')
-  }
-
   ds <- open_dataset(
     sources = source, schema = schema, partitioning = partitioning, hive_style = hive_style,
     unify_schemas = unify_schemas, format = "csv", quote = quote, escape_double = escape_double,
@@ -275,10 +261,6 @@ browser()
     read_options = read_options, timestamp_parsers = timestamp_parsers
   )
 
-  if (as_data_frame) {
-    return(as.data.frame(ds))
-  }
-
   ds
 }