Skip to content

Commit

Permalink
GH-33726: [CI][Go] Set host name in Go benchmarks (#33728)
Browse files Browse the repository at this point in the history
Closes #33726; see issue for comprehensive explanation. cc @ zeroshade 

### Rationale for this change

Go benchmarks are sending host names from runners that vary slightly, preventing us from seeing the full history of the benchmarks on Conbench.

### What changes are included in this PR?

Sets host name in Go benchmarks via environment variable so benchmark history will be available on Conbench.

### Are these changes tested?

Yes, for the benchadapt code that will pick it up: https://github.com/conbench/conbench/blob/main/benchadapt/python/tests/test_result.py#L107-L114

### Are there any user-facing changes?

No
* Closes: #33726

Authored-by: Edward Visel <1693477+alistaire47@users.noreply.github.com>
Signed-off-by: Jacob Wujciak-Jens <jacob@wujciak.de>
  • Loading branch information
alistaire47 committed Jan 17, 2023
1 parent 7319250 commit 705e04b
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/go.yml
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ jobs:
CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }}
CONBENCH_PASSWORD: ${{ secrets.CONBENCH_PASS }}
CONBENCH_REF: ${{ github.ref_name }}
CONBENCH_MACHINE_INFO_NAME: amd64-debian-11
run: |
pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python
python ci/scripts/go_bench_adapt.py
Expand Down Expand Up @@ -266,6 +267,7 @@ jobs:
CONBENCH_EMAIL: ${{ secrets.CONBENCH_EMAIL }}
CONBENCH_PASSWORD: ${{ secrets.CONBENCH_PASS }}
CONBENCH_REF: ${{ github.ref_name }}
CONBENCH_MACHINE_INFO_NAME: amd64-macos-11
run: |
pip install benchadapt@git+https://github.com/conbench/conbench.git@main#subdirectory=benchadapt/python
python ci/scripts/go_bench_adapt.py
Expand Down

0 comments on commit 705e04b

Please sign in to comment.