Remove SIMD Feature #5184
Merged
Remove SIMD Feature #5184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
commented
Dec 7, 2023
| @@ -610,7 +552,6 @@ pub fn gt_eq_utf8_scalar<OffsetSize: OffsetSizeTrait>( | |||
| /// Perform `left == right` operation on an array and a numeric scalar | |||
| /// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values. | |||
| /// | |||
| /// If `simd` feature flag is not enabled: | |||
There was a problem hiding this comment.
This hasn't actually been true since #4701
tustvold
commented
Dec 7, 2023
| /// Evaluate `op(left, right)` for [`PrimitiveArray`]s using a specified | ||
| /// comparison function. | ||
| #[deprecated(note = "Use BooleanArray::from_binary")] | ||
| pub fn no_simd_compare_op<T, F>( |
There was a problem hiding this comment.
I opted to just remove these as the no_simd was confusing in the abscence of an explicit SIMD version, and they were deprecated already
tustvold
commented
Dec 7, 2023
| /// Note that each slice should be 64 bytes and it is the callers responsibility to ensure | ||
| /// that this is the case. If passed slices larger than 64 bytes the operation will only | ||
| /// be performed on the first 64 bytes. Slices less than 64 bytes will panic. | ||
| #[cfg(feature = "simd")] |
There was a problem hiding this comment.
Interestingly arrow-buffer doesn't have a SIMD feature, so this has been silently not present by accident for a while. Likely since #2693
|
Ok, that then also fixes #5185 which I just created :) |
|
Changes look good to me 👍 |
7 tasks
viirya
approved these changes
Dec 7, 2023
jackwener
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Great job. Thanks @tustvold
Appreciate #5100 of @jhorstmann
This was referenced Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #46
Closes #54
Closes #2856
Closes #5185
Rationale for this change
#5100 removed the last major use of SIMD, so we can now remove this feature. I debated deprecating things first, but this got complicated as you can't really deprecate a trait, so I figured I would at least propose just ripping the band-aid off in one.
What changes are included in this PR?
Are there any user-facing changes?