fix: ensure take_fixed_size_list can handle null indices #5170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjones127
requested changes
Dec 5, 2023
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
reviewed
Dec 5, 2023
arrow-select/src/take.rs
Outdated
| @@ -689,7 +689,7 @@ fn take_value_indices_from_fixed_size_list<IndexType>( | |||
| where | |||
| IndexType: ArrowPrimitiveType, | |||
| { | |||
| let mut values = vec![]; | |||
| let mut values = Vec::with_capacity(length as usize * indices.len()); | |||
There was a problem hiding this comment.
On second thought, we should make this PrimitiveBuilder, since the conversion from Vec is no longer zero-copy when it's an Option.
wjones127
reviewed
Dec 5, 2023
Co-authored-by: Will Jones <willjones127@gmail.com>
wjones127
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5169
Rationale for this change
See issue
What changes are included in this PR?
The take implementation for fixed size list currently works by expanding the indices from "list indices" into "child indices". In other words, if the list is a fixed size list of 3 and the indices are
[0, 5]then it converts this into[0, 1, 2, 15, 16, 17]. This process was ignoring null indices and the result was that the child array would be too short. For example,[0, null]would turn into[0, 1, 2]which is too short. This PR propagates the null into the child index list. So now[0, null]turns into[0, 1, 2, null, null, null].Are there any user-facing changes?
None