Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Fix serialization of large integers (#5038) (#5042) to 48.0.0_maintenance #5059

Merged
merged 3 commits into from Nov 9, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 8, 2023

Which issue does this PR close?

Related to #5050

Rationale for this change

What changes are included in this PR?

Backports #5042, the fix for #5038

Are there any user-facing changes?

@alamb alamb added cherry-picked PR that was backported to active release (will be included in maintenance release) arrow Changes to the arrow crate labels Nov 8, 2023
@alamb alamb changed the title Backport Fix serialization of large integers (#5038) (#5042) to 48.0.0_maintenance Backport: Fix serialization of large integers (#5038) (#5042) to 48.0.0_maintenance Nov 8, 2023
@alamb alamb mentioned this pull request Nov 8, 2023
6 tasks
@alamb
Copy link
Contributor Author

alamb commented Nov 8, 2023

The CI test seems to be failing due to something unrelated: https://github.com/apache/arrow-rs/actions/runs/6803782852/job/18499862891?pr=5059

I will investigate more

##########################################################
C Data Interface: C++ exporting, Java importing
##########################################################
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/conda/envs/arrow/lib/python3.11/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/cli.py", line 787, in integration
    run_all_tests(**args)
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 638, in run_all_tests
    runner.run_c_data()
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 129, in run_c_data
    self._compare_c_data_implementations(producer, consumer)
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/runner.py", line 425, in _compare_c_data_implementations
    with consumer.make_c_data_importer() as importer:
         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/tester_java.py", line 349, in make_c_data_importer
    return JavaCDataImporter(self.debug, self.args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/__w/arrow-rs/arrow-rs/dev/archery/archery/integration/tester_java.py", line 89, in __init__
    import jpype
ModuleNotFoundError: No module named 'jpype'
ERROR conda.cli.main_run:execute(47): `conda run archery integration --run-flight --run-c-data --run-ipc --with-cpp=1 --with-csharp=1 --with-java=1 --with-js=1 --with-go=1 --with-rust=1 --gold-dirs=testing/data/arrow-ipc-stream/integration/0.14.1 --gold-dirs=testing/data/arrow-ipc-stream/integration/0.17.1 --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-bigendian --gold-dirs=testing/data/arrow-ipc-stream/integration/1.0.0-littleendian --gold-dirs=testing/data/arrow-ipc-stream/integration/2.0.0-compression --gold-dirs=testing/data/arrow-ipc-stream/integration/4.0.0-shareddict` failed. (See above for error)
Error: Process completed with exit code 1.

@alamb
Copy link
Contributor Author

alamb commented Nov 8, 2023

Seems to be the same as #4957 -- I will also backport the CI fixes

@alamb alamb merged commit a5027e8 into apache:48.0.0_maintenance Nov 9, 2023
22 checks passed
@alamb alamb deleted the alamb/backport_serde_fix branch November 9, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate cherry-picked PR that was backported to active release (will be included in maintenance release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants