GH-523: [Release] Add support for building .jar including JNI binaries #517
Conversation
kou
force-pushed
the
ci-rc-jni
branch
2 times, most recently
from
2b8fe63 to
76d58fc
Compare
| tar -xf apache-arrow-java-*.tar.gz --strip-components=1 | ||
| - name: Download the latest Apache Arrow C++ | ||
| run: | | ||
| ci/scripts/download_cpp.sh |
There was a problem hiding this comment.
We may want to use the main branch instead of related Apache Arrow C++ on daily run. But it's out-of-scope in this PR.
| - name: Extract Download the latest Apache Arrow C++ | ||
| run: | | ||
| tar -xf apache-arrow-java-*.tar.gz --strip-components=1 | ||
| # We need 19.0.0 for latest Boost support |
.github/workflows/rc.yml
Outdated
| upload: | ||
| name: Upload | ||
| if: github.ref_type == 'tag' | ||
| # if: github.ref_type == 'tag' |
There was a problem hiding this comment.
I'll revert this after I confirmed that this job works.
There was a problem hiding this comment.
Reverted. This worked: https://github.com/apache/arrow-java/actions/runs/12781206977/job/35629480932#step:3:17
.github/workflows/rc.yml
Outdated
| - name: Upload | ||
| run: | | ||
| # GH-499: How to create release notes? | ||
| version=${GITHUB_REF_NAME%-rc*} | ||
| version=${version#v} | ||
| rc=${GITHUB_REF_NAME#*-rc} | ||
| gh release create ${GITHUB_REF_NAME} \ | ||
| echo gh release create ${GITHUB_REF_NAME} \ |
There was a problem hiding this comment.
I'll revert this after I confirmed that this job works.
| - name: Checkout apache/arrow-testing | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| repository: apache/arrow-testing | ||
| path: arrow/testing | ||
| - name: Checkout apache/parquet-testing | ||
| uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| repository: apache/parquet-testing | ||
| path: arrow/cpp/submodules/parquet-testing |
There was a problem hiding this comment.
Do we need testing data? (I don't think we need to run C++ tests here?)
There was a problem hiding this comment.
OK. I'll disable C++ tests.
(I thought that we need to run C++ tests because it seems that we don't have enough test for JNI related codes.)
There was a problem hiding this comment.
The C++ tests we run here are just the same tests that apache/arrow already runs right? (I agree we need more testing for the JNI code itself, though...)
There was a problem hiding this comment.
Right but we use different build options that aren't covered by apache/arrow.
There was a problem hiding this comment.
Hmm if they're that different then should we be testing the config upstream? Or otherwise in that case I don't mind running the C++ tests here if our config is very different (it mostly just adds a lot of build time)
There was a problem hiding this comment.
OK. Let's do it in upstream.
…binaries Fixes apacheGH-500. Merge `test_jni.yml` to `rc.yml` so that .jar including JNI binaries can be released. ccache support is also enabled for fast CI.
|
CI passed. This is ready. |
kou
changed the title
kou
changed the title
|
I'll merge this today. I'll work on the followings as separated tasks:
|
Fixes GH-523.
Merge
test_jni.ymltorc.ymlso that .jar including JNI binaries can be built and uploaded to GitHub Releases for RC.ccache support is also enabled for fast CI.