Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-321: [Java] add new error expiration as part of endpoints information #322

Merged
merged 4 commits into from Aug 25, 2023
Merged

GH-321: [Java] add new error expiration as part of endpoints information #322

merged 4 commits into from Aug 25, 2023

Conversation

davisusanibar
Copy link
Contributor

To close #321

@davisusanibar
Copy link
Contributor Author

Also adding configuration ofAllow doctest_show_success=False option mention on sphinx-doc/sphinx#10938

@davisusanibar
Copy link
Contributor Author

Also adding configuration ofAllow doctest_show_success=False option mention on sphinx-doc/sphinx#10938

To fix error: https://github.com/apache/arrow-cookbook/actions/runs/5972085567/job/16202106444?pr=322

Exception occurred:
  File "/opt/hostedtoolcache/Python/3.9.17/x64/lib/python3.9/site-packages/sphinx/config.py", line 288, in __getattr__
    raise AttributeError(__('No such config value: %s') % name)
AttributeError: No such config value: doctest_show_successes

lidavidm
lidavidm reviewed Aug 25, 2023
View reviewed changes
java/ext/javadoctest.py Outdated
@@ -105,6 +105,7 @@ def setup(app) -> Dict[str, Any]:
app.add_directive("testoutput", TestoutputDirective)
app.add_builder(JavaDocTestBuilder)
# this config value adds to sys.path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment now is with the wrong line, can you move it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment now is with the wrong line, can you move it?

Please note that all configurations below are subject to this comment.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No: the comment is talking about doctest_path specifically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will update them now

lidavidm
lidavidm requested changes Aug 25, 2023
View reviewed changes
java/ext/javadoctest.py Outdated
@@ -105,6 +105,7 @@ def setup(app) -> Dict[str, Any]:
app.add_directive("testoutput", TestoutputDirective)
app.add_builder(JavaDocTestBuilder)
# this config value adds to sys.path
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No: the comment is talking about doctest_path specifically.

@lidavidm lidavidm merged commit d4e3b34 into apache:main Aug 25, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidavidm lidavidm lidavidm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Java] Fix current Java issue on Flight recipes
2 participants
@davisusanibar @lidavidm