Fix two Swift profiling bugs #3954
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initialiser creates an empty array. This means that indexed subscripts will be out of range. The Swift compiler amortises `.append` to effectively O(1). Signed-off-by: Chris Kolbu <chris.kolbu@ittybittyapps.com>
The current implementation using date object did not actually work (e.g the `timeInPrediction` was always zero). This has now been replaced by the preferred way to measure time in Swift. See discussion: https://forums.swift.org/t/recommended-way-to-measure-time-in-swift/33326 Signed-off-by: Chris Kolbu <chris.kolbu@ittybittyapps.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
ProfilingATNSimulatorinitialiser, from attempting to set values via subscript on an empty array.ProfilingATNSimulator.adaptivePredict's method that meant.timeInPredictionwould always report zero; this has now replaced by the preferred way to measure time in Swift.