Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consume wrapper classNames in drawer #48721

Merged
merged 1 commit into from
May 1, 2024

Conversation

replygirl
Copy link
Contributor

@replygirl replygirl commented Apr 30, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

N/A

💡 Background and solution

RcDrawer accepts a wrapper className, which is spread into antd config/prop types but unused

📝 Changelog

Language Changelog
🇺🇸 English 💄 Use classNames.wrapper in DrawerProps
🇨🇳 Chinese 💄 在DrawerProps中使用classNames.wrapper

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Signed-off-by: replygirl <moon@moon.fyi>
Copy link

stackblitz bot commented Apr 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 30, 2024

👁 Visual Regression Report for PR #48721 Passed ✅

🎯 Target branch: master (af465eb)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (af465eb) to head (f6bb523).

Additional details and impacted files
@@              Coverage Diff              @@
##           master    #48721        +/-   ##
=============================================
+ Coverage        0   100.00%   +100.00%     
=============================================
  Files           0       745       +745     
  Lines           0     12947     +12947     
  Branches        0      3383      +3383     
=============================================
+ Hits            0     12947     +12947     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 4e9af18 into ant-design:master May 1, 2024
66 checks passed
Copy link
Contributor

github-actions bot commented May 1, 2024

🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR).

🎉 感谢您的贡献!如果您还没有加入钉钉社区群,请扫描下方二维码加入我们(加群时请提供此 PR 链接)。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants