Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Slider tooltip should not display when open is false #48708

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 30, 2024

中文版模板 / Chinese template

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #48707

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Slider tooltip should not display when tooltip={{ open: false }}.
🇨🇳 Chinese 修复 Slider tooltip={{ open: false }} 时提示框未正确隐藏的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

stackblitz bot commented Apr 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

👁 Visual Regression Report for PR #48708 Passed ✅

🎯 Target branch: master (5fc3618)
📖 View Full Report ↗︎

🎊 Congrats! No visual-regression diff found.

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Preview is ready

Copy link
Contributor

github-actions bot commented Apr 30, 2024

size-limit report 📦

Path Size
./dist/antd.min.js 337.15 KB (+9 B 🔺)
./dist/antd-with-locales.min.js 385.01 KB (+158 B 🔺)

Copy link

codesandbox-ci bot commented Apr 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4d05229) to head (4f581b3).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #48708   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        12947     12947           
  Branches      3383      3383           
=========================================
  Hits         12947     12947           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider tooltip set to open: false, but still opens when active
2 participants